scanner: Use std::convert::Infallible in __phantom_lifetime variants
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 47 47
Lines 7779 7779
=======================================
Hits 5682 5682
Misses 2097 2097
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Looks good, can you add a changelog entry with that please? |
I thought there was an empty type in the standard library, but somehow couldn't find it when I implemented this. This makes it a bit more explicit that the variant is never constructed, and should help a bit with optimization. It does not impact public API.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought there was an empty type in the standard library, but somehow couldn't find it when I implemented this.
This makes it a bit more explicit that the variant is never constructed, and should help a bit with optimization. It does not impact public API.